Create lazy-style import decorator #1961
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates a lazy-esq style import decorator designed to be used with integrations that can optionally be there and require certain imports globally. This further improves on #1959, with a speed difference shown below (tl;dr 45% speedup):
Before change, with all tracking modules available:
After change:
How does it work?
This operates by writing a decorator with the exact module to be imported later. In the same function that is decorated,
global {mymodule}
should be declared and assigned toaccelerate.utils.imports.{mymodule}
, where it'll be imported from.The main con here is we lose static checking, however the argument here is immense speedup and flexibility, while reserving this just for integrations.
Fixes # (issue)
Lays foundation to solve #1952
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan @SunMarc